Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] doc: correct async_hooks resource names #24684

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] doc: correct async_hooks resource names #24684

wants to merge 1 commit into from

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Nov 27, 2018

Correct async hooks resource names to match the implementation:
TCPSERVER => TCPSERVERWRAP

Refs: #17157
Refs: #24001

Checklist

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. v8.x labels Nov 27, 2018
@Trott
Copy link
Member

Trott commented Nov 30, 2018

Needs a rebase or something? Seems to have far too many commits.

Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`

Refs: #17157
@Flarna
Copy link
Member Author

Flarna commented Nov 30, 2018

No idea what exactly I did wrong but it should be corrected now.

BethGriggs pushed a commit that referenced this pull request Dec 3, 2018
Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`

Refs: #17157

PR-URL: #24684
Refs: #17157
Refs: #24001
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs
Copy link
Member

Landed in f5683a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants